-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the hoodie ci s3 test failed. #446
base: master
Are you sure you want to change the base?
Conversation
The CI can pass when one branch in this project wants to merge to the master, but it will fail when the forked repo wants to merge PR to the master. It is not friendly for community users to contribute PR to this repo. I think we can disable the S3 test. Do you have any ideas? @zymap |
We can run that test when the PR is merged into the master, and for pull-request, we can skip it. We can separate the cloud-related test, and only trigger it running using the condition:
Then, run the remaining tests in the usual pull request checks. |
make sense |
I'm not sure I got the idea clearly, please help to review it. Thanks @zymap |
Motivation
The HoodieWriterTest will run ci with s3, but the env is not set, so the test can't pass. I think we can disable the s3 in the ci.
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)