services/horizon: Add more validations for the NETWORK parameter #4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urvisavla
force-pushed
the
4913/captive-core-enabled-validation
branch
2 times, most recently
from
a861a7d
to
8d86709
Compare
7 tasks
tamirms
reviewed
Jul 28, 2023
urvisavla
force-pushed
the
4913/captive-core-enabled-validation
branch
from
8d86709
to
b423428
Compare
…ing config params when NETWORK param is used: ENABLE_CAPTIVE_CORE_INGESTION, INGEST, NETWORK_ARCHIVE_URLS, NETWORK_PASSPHRASE, STELLAR_CORE_BINARY_PATH, and CAPTIVE_CORE_CONFIG_PATH 2. Validate that the stellar-core binary is installed and available in OS PATH
|
After discussing with the team, we've reached a decision regarding the behavior of the individual parameters when NETWORK is specified. Closing the PR as it's no longer necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Show an error message if the
NETWORKparameter is provided, butENABLE_CAPTIVE_CORE_INGESTIONis set to false.Why
The
NETWORKparameter is intended to simplify captive core configuration, and it has no effect if captive-core is disabled.Known limitations
[TODO or N/A]