Services/horizon: Integration tests for NETWORK parameter #4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urvisavla
force-pushed
the
params-integration-tests
branch
5 times, most recently
from
7b28b9f
to
6ad3e7d
Compare
tamirms
reviewed
Jul 25, 2023
sreuland
reviewed
Jul 25, 2023
sreuland
reviewed
Jul 25, 2023
sreuland
reviewed
Jul 25, 2023
sreuland
reviewed
Jul 25, 2023
urvisavla
force-pushed
the
params-integration-tests
branch
2 times, most recently
from
cc2a142
to
c683ac3
Compare
urvisavla
force-pushed
the
params-integration-tests
branch
from
5f926c6
to
42d20e0
Compare
…starts successfully with the default configuration when the NETWORK parameter is set to either "pubnet" or "testnet".
…unction with other parameters that are not allowed. Additionally, modified StartHorizon() function to return an error message in case of failure instead of just exiting. Updated an existing test to use the modified behaviour.
urvisavla
force-pushed
the
params-integration-tests
branch
from
c36e824
to
b5ea885
Compare
sreuland
reviewed
Aug 8, 2023
sreuland
reviewed
Aug 8, 2023
sreuland
reviewed
Aug 8, 2023
sreuland
reviewed
Aug 8, 2023
sreuland
reviewed
Aug 8, 2023
sreuland
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Introduce integration tests to verify that Horizon starts successfully with the default configuration when the NETWORK parameter is set to either "pubnet" or "testnet". The tests cover
Networkparameter using both command-line argument and environment variable. Added support to skip starting core containers for running these tests.Updated the
StartHorizon()function to return the error instead of just exiting. Updated the existing test that was affected by it.Fixed an issue in an existing test where it failed to clean up the environment variable properly.
Why
closes #4967
Known limitations
Typically during integration tests, we initiate Horizon in standalone mode and simultaneously start the stellar-core container in standalone mode as well. We wait for Horizon to begin ingesting to verify the test's success. However, in the case of "pubnet" or "testnet," waiting for Horizon to start ingesting is not practical. As a result, we run only validate that the Horizon successfully starts the captive-core subprocess using the default configuration.