Fix Ecto 3.0 warnings #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbernheisel
commented
Nov 8, 2018
| @@ -18,7 +18,7 @@ defmodule Arc.Ecto.Schema do | |||
| end | |||
|
|
|||
| # Cast supports both atom and string keys, ensure we're matching on both. | |||
| allowed = Enum.map(allowed, fn key -> | |||
There was a problem hiding this comment.
this reassigned the keys passed in from cast_attachment() which are atoms.
|
I opened an issue at arc repository about the error logs. Do you think this PR will solve it too? By the way, thanks for the amazing job! |
|
@williamweckl if you mean that while running your app tests, it throws |
williamweckl
approved these changes
Nov 16, 2018
|
Any chance this gets merged soon? Has the project been abandoned? |
Closed
novaugust
pushed a commit
to GetThru/arc_ecto
that referenced
this pull request
Apr 1, 2019
Fix Ecto 3.0 warnings Conflicts: mix.exs test/schema_test.exs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102. Related #98 #99 #101. Same work is done in #101 and #99, except this PR doesn't bump the ecto requirement or use the formatter.
I didn't find it necessary to update the project's Ecto requirement. This should continue to work fine with Ecto 2.x, as well as silence the errors emitted with Ecto 3.x. I've tested this locally.
Sidenotes: