Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo: Support Ecto 3 #98

Closed
mmartinson opened this issue Oct 4, 2018 · 5 comments
Closed

Todo: Support Ecto 3 #98

mmartinson opened this issue Oct 4, 2018 · 5 comments

Comments

@mmartinson
Copy link

Ecto 3 is coming in the next couple days and with it the recommended upgrade path for those using it for database interaction is to change dependency from ecto to ecto_sql.

I think to support backwards compatibly for presumably a long time we'll want to introduce an optional dependency.

Reference commit and announcement

@idyll
Copy link

idyll commented Oct 24, 2018

One of the changes that's needed is in cast_attachments

The allowed params in:

cast(changeset_or_data, arc_params, allowed)

are converted into strings. Which triggers all sorts of warnings because they should be atoms.

@nathany
Copy link

nathany commented Nov 1, 2018

It seems that the test suite doesn't require ecto_sql.

#101 amends #99 for Ecto 3.0 final. @tarzan resolved the warnings.

Do you want to support Ecto 2.x and 3.x simultaneously, or just release a new major version that requires Ecto 3? [people can always use an old version of arc_ecto]

@williamweckl
Copy link

Any updates on this?

@dbernheisel
Copy link
Contributor

I think this issue is resolved with #103

@williamweckl
Copy link

@dbernheisel Yes it is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants