Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 1695 by not updating ancestors on zap #1766

Merged
merged 2 commits into from
Dec 27, 2024
Merged

fix 1695 by not updating ancestors on zap #1766

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a77c215
fix 1695 by not updating ancestors on zap
huumn Dec 27, 2024
970f741
update ancestors but only onPaid
huumn Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion components/item-act.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ export default function ItemAct ({ onClose, item, act = 'TIP', step, children, a

function modifyActCache (cache, { result, invoice }) {
if (!result) return
const { id, sats, path, act } = result
const { id, sats, act } = result
cache.modify({
id: `Item:${id}`,
fields: {
Expand Down Expand Up @@ -211,7 +211,13 @@ function modifyActCache (cache, { result, invoice }) {
}
}
})
}

// doing this onPaid fixes issue #1695 because optimistically updating all ancestors
// conflicts with the writeQuery on navigation from SSR
function updateAncestors (cache, { result, invoice }) {
if (!result) return
const { id, sats, act, path } = result
if (act === 'TIP') {
// update all ancestors
path.split('.').forEach(aId => {
Expand Down Expand Up @@ -259,6 +265,7 @@ export function useAct ({ query = ACT_MUTATION, ...options } = {}) {
onPaid: (cache, { data }) => {
const response = getPaidActionResult(data)
if (!response) return
updateAncestors(cache, response)
options?.onPaid?.(cache, { data })
}
})
Expand Down
Loading