fix 1695 by not updating ancestors on zap #1766
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running out of less severe changes to fix this bug. I describe the problem in #1695 some, but the gist is:
writeQuery
to merge SSR data with the cachewriteQuery
does not support merging into optimistic caches, so until the real response returns, the stale optimistic cache (which does not yet have the item in the thread) is shown(I should note this happens in more places than just notifications, so doing a hack checking the pathname is especially not worth it.)
This fixes the problem by avoiding a need to merge the ancestors in the thread. BUT it means the
commentSats
which displays at the top of comment threads never updates in response to zaps. The tradeoff is worth it, but I'd prefer to not have to make it.I'll try a few more fixes, but there aren't many things left to try.
I wound up updating ancestors
onPaid
... we still can updatecommentSats
(with some delay) and this write conflict doesn't happen.