Create non-@MainActor-bound methods for rounding to pixel at scale #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
commented
Oct 30, 2024
| @@ -27,7 +27,7 @@ public protocol ScaleFactorProviding { | |||
| extension UIScreen: ScaleFactorProviding { | |||
|
|
|||
| public var pixelsPerPoint: CGFloat { | |||
| return scale | |||
There was a problem hiding this comment.
I did some stylizing in this file while I was here 😅
dfed
force-pushed
the
dfed--main-actor-less
branch
2 times, most recently
from
35ddc34 to
1d74c6b
Compare
|
A (much more breaking) alternative that might be worth considering here is removing pixel rounding from aspectRatio.size(forWidth: ...).ceiledToPixel()or aspectRatio.size(forWidth: ...).flooredToPixel()Not tonight though. Let's open an issue for this. |
dfed
force-pushed
the
dfed--main-actor-less
branch
from
1d74c6b to
5446950
Compare
dfed
commented
Oct 30, 2024
Comment on lines
-61
to
-67
| extension Int: ScaleFactorProviding { | ||
|
|
||
| public var pixelsPerPoint: CGFloat { | ||
| return CGFloat(self) | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
big ol' breaking change. but... I doubt this is used much.
dfed
force-pushed
the
dfed--main-actor-less
branch
from
5446950 to
0267011
Compare
NickEntin
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #132 we made it difficult to work with aspect ratios when the scale factor is known a-priori and does not need to be derived on the main actor. Here we make it easy again through the magic of copy and paste.