Make it possible to do rounding calculations off of @MainActor when scale is known #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
force-pushed
the
dfed--scale-factor-off-main
branch
from
e44aa9c to
649562d
Compare
|
Closing in favor of #140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#132 left us in a place where we cannot do pixel rounding at constant scales when off of
@MainActor. I expected this would be fine, but upon an attempt to adopt of latestmasterI've realized thatnonisolateddelegate methods can be hampered by this approach.This PR introduces the concept of
CGFloatProviding, to whichCGFloatandIntboth conform. Both of these types no longer conform toScaleFactorProviding, and for every method that takes ascaleFactor: ScaleFactorProvidingI have created a duplicate, non-@MainActor-bound method that takes ascale: CGFloatProvidingand made thescaleFactor-taking method call through to this newscale-taking method.This PR creates a good amount of duplicated API surface – I'm not convinced this is the best possible approach. Very open to feedback, but I do think we'll want to solve this problem before creating the next release.