Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated language DOC-1037 #34

Merged
merged 2 commits into from
Jan 23, 2024
Merged

docs: updated language DOC-1037 #34

merged 2 commits into from
Jan 23, 2024

Conversation

karl-cardenas-coding
Copy link
Collaborator

@karl-cardenas-coding karl-cardenas-coding commented Jan 22, 2024

Describe the Change

This PR removes words that are not considered inclusive from the codebase. In addition to the word changes. A license header is also applied to all files. Authors can use the Makefile command make licenses to apply a header to all new files. This requires the installation of HashiCorp Copywrite tool.

Review Changes

🎫 DOC-1037

@karl-cardenas-coding karl-cardenas-coding added the documentation Improvements or additions to documentation label Jan 22, 2024
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner January 22, 2024 22:50
@karl-cardenas-coding karl-cardenas-coding requested review from addetz, lennessyy and caroldelwing and removed request for a team January 22, 2024 22:50
Copy link
Contributor

@addetz addetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about contributions going forward.



license: ## Adds a license header to all files. Reference https://github.com/hashicorp/copywrite to learn more.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this command and the install of the copywrite tool to CONTRIBUTION.md?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the tool inside the container image as it's only used for repo maintenance. The only tools we list in that file are tools added to the image.

@karl-cardenas-coding karl-cardenas-coding merged commit 0557096 into main Jan 23, 2024
3 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the word-removal branch January 23, 2024 14:13
Copy link

🎉 This PR is included in version 1.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants