Language Clean-up #2089

karl-cardenas-coding · 2024-01-22T23:33:21Z

Describe the Change

This PR updates the documentation code base by removing all instances of master/slave. There is one instance that we cannot remove yet and that is due to PEM-4430

❗ Dependent on PR 34 ✅

Review Changes

💻 Preview URL

🎫 DOC-1033

netlify · 2024-01-22T23:33:28Z

✅ Deploy Preview for docs-spectrocloud ready!

Name	Link
🔨 Latest commit	`8ee2f07`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-spectrocloud/deploys/65b305d8c470fd0008c4af5d
😎 Deploy Preview	https://deploy-preview-2089--docs-spectrocloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-01-25T17:45:37Z

docs/docs-content/registries-and-packs/pack-constraints.md

- all - pods are scheduled on both master and worker nodes
+Kubernetes provides a way to schedule the pods on the control plane and worker nodes. Pack Constraints framework must
+know where the pods are scheduled because the resource validation validates only the control plane machine pool when the
+pods are scheduled on control plane nodes. Similarily, if the pods are scheduled on worker nodes, then only the worker


🚫 [vale] _{reported by reviewdog 🐶}
[Vale.Spelling] Did you really mean 'Similarily'?

docs/docs-content/clusters/edge/site-deployment/site-installation/cluster-deployment.md

github-actions · 2024-01-25T17:45:37Z

docs/docs-content/clusters/public-cloud/aws/create-cluster.md

    [instance cost type](architecture.md#spot-instances), disk size, and the number of nodes. Click on **Next** after
    you have completed configuring the node pool. The minimum number of CPUs and amount of memory depend on your cluster
-    profile, but in general you need at least 4 CPUs and 4 GB of memory both in the master pool and across all worker
-    pools.
+    profile, but in general you need at least 4 CPUs and 4 GB of memory both in the control plane pool and across all


🚫 [vale] _{reported by reviewdog 🐶}
[Vale.Spelling] Did you really mean 'CPUs'?

github-actions · 2024-01-25T17:45:38Z

docs/docs-content/clusters/public-cloud/gcp/create-gcp-iaas-cluster.md

-    least 4 CPUs and 4 GB of memory both in the master pool and across all worker pools.
+    number of nodes. Configure the control plane and worker node pools. A control plane and a worker node pool are
+    configured by default. The minimum number of CPUs and amount of memory depend on your cluster profile, but in
+    general you need at least 4 CPUs and 4 GB of memory both in the control plane pool and across all worker pools.


🚫 [vale] _{reported by reviewdog 🐶}
[Vale.Spelling] Did you really mean 'CPUs'?

github-actions · 2024-01-25T17:45:38Z

docs/docs-content/clusters/public-cloud/gcp/create-gcp-gke-cluster.md

@@ -68,8 +68,8 @@ Ensure the following requirements are met before you attempt to deploy a cluster

 11. The Node configuration page is where you can specify the availability zones (AZ), instance types, disk size, and the
    number of nodes. Configure the worker node pool. The minimum number of CPUs and amount of memory depend on your
-    cluster profile, but in general you need at least 4 CPUs and 4 GB of memory both in the master pool and across all
-    worker pools.
+    cluster profile, but in general you need at least 4 CPUs and 4 GB of memory both in the control plane pool and


🚫 [vale] _{reported by reviewdog 🐶}
[Vale.Spelling] Did you really mean 'CPUs'?

github-actions · 2024-01-25T17:45:38Z

docs/docs-content/clusters/cluster-management/cloud-cost.md

-| WORKER POOL  | 3    | AWS t2.large($0.0992/hour)  | 60GB - gp2($0.00014/GB/hour) |
+| MACHINE POOL  | SIZE | INSTANCE TYPE WITH COST     | ROOT DISK WITH COST          |
+| ------------- | ---- | --------------------------- | ---------------------------- |
+| Control Plane | 3    | AWS t2.medium($0.0496/hour) | 60GB - gp2($0.00014/GB/hour) |


🚫 [vale] _{reported by reviewdog 🐶}
[Google.Units] Put a nonbreaking space between the number and the unit in '60GB'.

github-actions · 2024-01-25T17:45:38Z

docs/docs-content/clusters/cluster-management/cloud-cost.md

+| MACHINE POOL  | SIZE | INSTANCE TYPE WITH COST     | ROOT DISK WITH COST          |
+| ------------- | ---- | --------------------------- | ---------------------------- |
+| Control Plane | 3    | AWS t2.medium($0.0496/hour) | 60GB - gp2($0.00014/GB/hour) |
+| Worker Pool   | 3    | AWS t2.large($0.0992/hour)  | 60GB - gp2($0.00014/GB/hour) |


🚫 [vale] _{reported by reviewdog 🐶}
[Google.Units] Put a nonbreaking space between the number and the unit in '60GB'.

github-actions · 2024-01-25T17:45:38Z

docs/docs-content/clusters/cluster-management/compliance-scan.md

-tool called KubeBench from Aqua Security to perform this scan. Scans are run against master and worker nodes of the
-Kubernetes cluster, and a combined report is made available on the UI. Users can filter the report to view only the
-master or worker results if required.
+tool called KubeBench from Aqua Security to perform this scan. Scans are run against control plane and worker nodes of


🚫 [vale] _{reported by reviewdog 🐶}
[spectrocloud.ableism] Avoid using ableism terms. Use 'issue' instead of 'run'.

github-actions · 2024-01-25T17:45:38Z

docs/docs-content/clusters/clusters.md

@@ -65,14 +65,14 @@ available to the users to apply to their existing clusters at a time convenient
 ### Kubernetes

 Kubernetes components and configuration are hardened in accordance with the Kubernetes CIS Benchmark. Palette executes
-Kubebench, a CIS Benchmark scanner by Aqua Security, for every Kubernetes pack to ensure the master and worker nodes are
-configured securely.
+Kubebench, a CIS Benchmark scanner by Aqua Security, for every Kubernetes pack to ensure the control plane and worker


🚫 [vale] _{reported by reviewdog 🐶}
[Vale.Spelling] Did you really mean 'Kubebench'?

src/components/IconMapper/dynamicFontAwesomeImports.js

…removal

vault-token-factory-spectrocloud · 2024-01-26T01:26:36Z

💔 Some backports could not be created

Status	Branch	Result
❌	version-4-0	Backport failed because of merge conflicts
❌	version-3-4	Backport failed because of merge conflicts You might need to backport the following PRs to version-3-4: - Refactor/restructure cluster & app profiles sections (#1551) - docs: refactor for self-hosted Palette DOC-465 (#1597) - docs: updated URLs to use file path context
❌	version-4-1	Backport failed because of merge conflicts
✅	version-4-2

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 2089

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud · 2024-04-05T22:47:27Z

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

vault-token-factory-spectrocloud · 2024-04-06T06:01:24Z

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

docs: remove master/slave DOC-DOC-1033 PEM-4404

61b8d93

karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 labels Jan 22, 2024

karl-cardenas-coding added the documentation Improvements or additions to documentation label Jan 22, 2024

karl-cardenas-coding added 2 commits January 23, 2024 07:28

docs: updated tutorials version

91a30db

docs: more instances found

941d266

karl-cardenas-coding marked this pull request as ready for review January 25, 2024 17:44

karl-cardenas-coding requested a review from a team as a code owner January 25, 2024 17:44

karl-cardenas-coding requested review from yuliiiah, addetz and lennessyy January 25, 2024 17:44

github-actions bot reviewed Jan 25, 2024

View reviewed changes

Merge branch 'master' into word-removal

02e4522

addetz approved these changes Jan 25, 2024

View reviewed changes

src/components/IconMapper/dynamicFontAwesomeImports.js Outdated Show resolved Hide resolved

karl-cardenas-coding added 5 commits January 25, 2024 10:56

chore: rebase from master

36b29cc

Merge branch 'master' of github.com:spectrocloud/librarium into word-…

6a1f9a9

…removal

Merge branch 'master' into word-removal

e1e0cc3

chore: updated link in vale rule

2b77597

docs: fixed format

8ee2f07

karl-cardenas-coding merged commit dbf675d into master Jan 26, 2024
9 checks passed

karl-cardenas-coding deleted the word-removal branch January 26, 2024 01:25

vault-token-factory-spectrocloud bot mentioned this pull request Jan 26, 2024

[version-4-2] docs: remove master/slave DOC-1033 PEM-4404 #2123

Merged

This was referenced Jan 26, 2024

[version-3-4] docs: remove master/slave DOC-1033 PEM-4404 #2124

Merged

[version-4-0] docs: remove master/slave DOC-1033 PEM-4404 #2125

Merged

[version-4-1] docs: Backport/version 4 1/pr 2089 #2126

Merged

vault-token-factory-spectrocloud bot added the released label Apr 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Language Clean-up #2089

Language Clean-up #2089

karl-cardenas-coding commented Jan 22, 2024 •

edited

Loading

netlify bot commented Jan 22, 2024 •

edited

Loading

github-actions bot Jan 25, 2024

github-actions bot Jan 25, 2024

github-actions bot Jan 25, 2024

github-actions bot Jan 25, 2024

github-actions bot Jan 25, 2024

github-actions bot Jan 25, 2024

github-actions bot Jan 25, 2024

github-actions bot Jan 25, 2024

vault-token-factory-spectrocloud bot commented Jan 26, 2024

vault-token-factory-spectrocloud bot commented Apr 5, 2024

vault-token-factory-spectrocloud bot commented Apr 6, 2024

Language Clean-up #2089

Language Clean-up #2089

Conversation

karl-cardenas-coding commented Jan 22, 2024 • edited Loading

Describe the Change

Review Changes

netlify bot commented Jan 22, 2024 • edited Loading

✅ Deploy Preview for docs-spectrocloud ready!

github-actions bot Jan 25, 2024

Choose a reason for hiding this comment

github-actions bot Jan 25, 2024

Choose a reason for hiding this comment

github-actions bot Jan 25, 2024

Choose a reason for hiding this comment

github-actions bot Jan 25, 2024

Choose a reason for hiding this comment

github-actions bot Jan 25, 2024

Choose a reason for hiding this comment

github-actions bot Jan 25, 2024

Choose a reason for hiding this comment

github-actions bot Jan 25, 2024

Choose a reason for hiding this comment

github-actions bot Jan 25, 2024

Choose a reason for hiding this comment

vault-token-factory-spectrocloud bot commented Jan 26, 2024

💔 Some backports could not be created

Manual backport

Questions ?

vault-token-factory-spectrocloud bot commented Apr 5, 2024

vault-token-factory-spectrocloud bot commented Apr 6, 2024

karl-cardenas-coding commented Jan 22, 2024 •

edited

Loading

netlify bot commented Jan 22, 2024 •

edited

Loading