-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help output correctly decides when to show the version option #1664
Open
FrankRay78
wants to merge
16
commits into
spectreconsole:main
Choose a base branch
from
FrankRay78:Help-writer-displays-version-option-correctly
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Help output correctly decides when to show the version option #1664
FrankRay78
wants to merge
16
commits into
spectreconsole:main
from
FrankRay78:Help-writer-displays-version-option-correctly
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests had incorrect expectations for the parsing of branch + default command arguments
…irst argument, even if a default command has been set.
This was referenced Oct 9, 2024
FrankRay78
changed the title
Help output shows / hides version option correctly (DRAFT)
Help output decides when to show the version option correctly (DRAFT)
Oct 9, 2024
FrankRay78
changed the title
Help output decides when to show the version option correctly (DRAFT)
Help output correctly decides when to show the version option (DRAFT)
Oct 9, 2024
…cified, rather than showing the ApplicationVersion number
…hould (and shouldn't) appear in the help output
FrankRay78
force-pushed
the
Help-writer-displays-version-option-correctly
branch
from
October 14, 2024 10:41
9919872
to
dae2041
Compare
FrankRay78
changed the title
Help output correctly decides when to show the version option (DRAFT)
Help output correctly decides when to show the version option
Oct 15, 2024
Fully implemented and ready for reviewImportant: Please see the comment at the top of the issue description ahead of merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of CLI bug fixes/enhancements intended to be released prior to Spectre.Console V1.0
They should be individually reviewed and merged (and then the open ones rebased) in the following order, given they have been successively branched from each other (Rationale: earlier changes, particularly to CommandExecutor, are relied upon later). Separate PRs should aid the reviewer.
fixes #1567, #1479
Changes
Version information applies to the entire CLI application.
Whether to show the "-v|--version" option in the help is determined as per:
Please upvote 👍 this pull request if you are interested in it.