Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsed unknown flag to remaining arguments for a branch with a default command #1660

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

FrankRay78
Copy link
Contributor

@FrankRay78 FrankRay78 commented Oct 5, 2024

This PR is part of a series of CLI bug fixes/enhancements intended to be released prior to Spectre.Console V1.0

They should be individually reviewed and merged (and then the open ones rebased) in the following order, given they have been successively branched from each other (Rationale: earlier changes, particularly to CommandExecutor, are relied upon later). Separate PRs should aid the reviewer.

  1. Add parsed unknown flag to remaining arguments for a branch with a default command #1660 (this one)
  2. Correctly show application version; execution of command with version option #1663
  3. Help output correctly decides when to show the version option #1664

fixes #1607

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

  • New unit tests to ensure unknown flags are added to remaining args
  • Add strict parsing to almost all branches tests (an obvious omission from a prior PR)
  • Fixed tests with incorrect validation that were in the main branch
  • Significant improvement to the command line parsing to implement the above

Please upvote 👍 this pull request if you are interested in it.

@FrankRay78 FrankRay78 self-assigned this Oct 5, 2024
@FrankRay78 FrankRay78 added the area-CLI Command-Line Interface label Oct 5, 2024
@FrankRay78 FrankRay78 added this to the 0.50 milestone Oct 5, 2024
@FrankRay78 FrankRay78 added the bug Something isn't working label Oct 5, 2024
@FrankRay78 FrankRay78 requested a review from a team October 5, 2024 21:00
@FrankRay78 FrankRay78 changed the title Add parsed unknown flag to remaining arguments for a branch (or branch of a branch) with a default command Add parsed unknown flag to remaining arguments for a branch with a default command Oct 9, 2024
@FrankRay78
Copy link
Contributor Author

Fully implemented and ready for review

Important: Please see the comment at the top of the issue description ahead of merging.

@patriksvensson patriksvensson modified the milestones: 0.50, 0.51 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CLI Command-Line Interface bug Something isn't working
Projects
Status: PR 📬
2 participants