Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV stream callback fixed #170

Merged
merged 4 commits into from
Apr 24, 2024
Merged

CSV stream callback fixed #170

merged 4 commits into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. CSV stream callback fixed 

    If we use callback to write content, we must open the OpenSpout writer. So it basically calls twice, which makes problem on CSV.

openToBrowser function also need the file name inside closure. So I've added the $downloadName as an argument.
    @rakibhoossain
    rakibhoossain authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    1daa1d9 View commit details
    Browse the repository at this point in the history

  2. Ternary instead of else

    @rakibhoossain
    rakibhoossain authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    609d60b View commit details
    Browse the repository at this point in the history

  3. Stream callback sample 

    Stream callback function example
    @rakibhoossain
    rakibhoossain authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7984407 View commit details
    Browse the repository at this point in the history

  4. Update README.md

    @freekmurze
    freekmurze authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9520756 View commit details
    Browse the repository at this point in the history