CSV stream callback fixed #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use callback to write content, we must open the OpenSpout writer. So it basically calls twice, which makes problem on CSV. openToBrowser function also need the file name inside closure. So I've added the $downloadName as an argument.
|
Sample usages of the function: SimpleExcel::streamDownload(downloadName: $name, writerCallback: function ($writerCallback, $downloadName) {
$writerCallback->openToBrowser($downloadName);
$row = Row::fromValues([
'first_name' => 'Rakib',
'last_name' => 'Hossain',
]);
$writerCallback->addRow($row);
}); |
freekmurze
requested changes
Apr 24, 2024
src/SimpleExcelWriter.php
Outdated
| @@ -68,11 +68,11 @@ public static function streamDownload( | |||
| $writer = $simpleExcelWriter->getWriter(); | |||
|
|
|||
| if ($writerCallback) { | |||
| $writerCallback($writer); | |||
| $writerCallback($writer, $downloadName); | |||
| } else { | |||
There was a problem hiding this comment.
Could you use a ternary instead of else?
There was a problem hiding this comment.
Yes, I've updated it.
|
Could you also update the readme with an example on how to use this? |
Stream callback function example
I've added example on readme file. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use callback to write content, we must open the OpenSpout writer. So it basically calls twice, which makes problem on CSV.
openToBrowserfunction also need the file name inside closure. So I've added the$downloadNameas an argument.