Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use webbpsf data from grp in jenkins runs #918

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 2, 2023

The url used to fetch webbpsf data for the jenkins runs:

https://stsci.box.com/shared/static/0ojjfg3cieqdpd18vl1bjnpe63r82dx8.gz

Appears to be down (regression test runs are failing to start and attempting to access the url locally results in a 'file upload in progress' page).

This PR updates the jenkins configuration files to use the webbpsf data on /grp/ that is newly available from the webbpsf team as described in the docs:
https://webbpsf.readthedocs.io/en/latest/installation.html

Regression tests successfully run (these were started after the above url went down): https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FRoman-Developers-Pull-Requests/detail/Roman-Developers-Pull-Requests/396/pipeline/220

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@braingram braingram force-pushed the webbpsf_grp branch 2 times, most recently from fc31f5c to ed165ec Compare October 3, 2023 13:44
@braingram
Copy link
Collaborator Author

CI failures are unrelated to these changes and are also occurring on main:
https://github.com/spacetelescope/romancal/actions/runs/6394475030/job/17355965466#step:10:201

@braingram braingram force-pushed the webbpsf_grp branch 2 times, most recently from df22046 to 4eca60d Compare October 18, 2023 14:08
Copy link
Collaborator

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and should work going forward.

@braingram braingram merged commit b4952b7 into spacetelescope:main Nov 9, 2023
27 checks passed
@braingram braingram deleted the webbpsf_grp branch November 9, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants