update compare_asdf to use tolerance in more comparisons #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide ``atol`` to ``DeepDiff`` as ``math_epsilon`` argument to allow tolerancing scalar comparisons. Drop use of ``astropy.utils.diff.values_differ`` as it does not provide readable output and does not allow control of ``nan`` equality. Instead, convert the table to a numpy structured array during comparison. Add support for numpy structured array comparison.
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
mairanteodoro
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide
atoltoDeepDiffasmath_epsilonargument to allow tolerancing scalar comparisons.Drop use of
astropy.utils.diff.values_differas it does not provide readable output and does not allow control ofnanequality. Instead, convert the table to a numpy structured array during comparison.Add support for numpy structured array comparison.
Fixes #916
Checklist
CHANGES.rstunder the corresponding subsectionRegression tests running at: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/395/Regression tests are failing due to unavailable webbpsf data. #918 fixes the issue for the regression tests.
EDIT: the url used to fetch the data appears to be back up (for now, box is having issues), a new run passed with no errors: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FRoman-Developers-Pull-Requests/detail/Roman-Developers-Pull-Requests/397/pipeline