Remove SourceDetection rename source_detection to source_catalog

[braingram]

This PR:

• removes SourceDetectionStep
• update romancal to accomdate changes in Rename source_detection to source_catalog rad#513 which renamed
  • meta.source_detection to meta.source_catalog
  • meta.cal_step.source_detection to meta.cal_step.souce_catalog
  • SourceCatalog to ImageSourceCatalog (to deal with schema name conflicts with the above renaming and to make this agree with MosaicSourceCatalog)

As the above renaming breaks reading current files a new set of regtest data was generated:
roman-pipeline/dev_20241127/
all tests pass locally.
This PR also makes several changes to make_regtest_data.sh to deal with a few issues. I will call them out in comments.

Regtests (with existing files showing many expected failures): https://github.com/spacetelescope/RegressionTests/actions/runs/11942934325

Running regtests with new truth files: https://github.com/spacetelescope/RegressionTests/actions/runs/12144666599

Tasks

• request a review from someone specific, to avoid making the maintainers review every PR
• add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

news fragment change types...

• changes/<PR#>.general.rst: infrastructure or miscellaneous change
• changes/<PR#>.docs.rst
• changes/<PR#>.stpipe.rst
• changes/<PR#>.associations.rst
• changes/<PR#>.scripts.rst
• changes/<PR#>.mosaic_pipeline.rst
• changes/<PR#>.patch_match.rst

steps

• changes/<PR#>.dq_init.rst
• changes/<PR#>.saturation.rst
• changes/<PR#>.refpix.rst
• changes/<PR#>.linearity.rst
• changes/<PR#>.dark_current.rst
• changes/<PR#>.jump_detection.rst
• changes/<PR#>.ramp_fitting.rst
• changes/<PR#>.assign_wcs.rst
• changes/<PR#>.flatfield.rst
• changes/<PR#>.photom.rst
• changes/<PR#>.flux.rst
• changes/<PR#>.source_detection.rst
• changes/<PR#>.tweakreg.rst
• changes/<PR#>.skymatch.rst
• changes/<PR#>.outlier_detection.rst
• changes/<PR#>.resample.rst
• changes/<PR#>.source_catalog.rst

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.77%. Comparing base (20b1fdf) to head (967c03f).
Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
romancal/tweakreg/tweakreg_step.py	80.00%	2 Missing ⚠️
romancal/pipeline/exposure_pipeline.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1533       +/-   ##
===========================================
+ Coverage   28.01%   76.77%   +48.76%     
===========================================
  Files         116      118        +2     
  Lines        7728     7747       +19     
===========================================
+ Hits         2165     5948     +3783     
+ Misses       5563     1799     -3764     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[braingram]

Temporarily pointing to the source branch for spacetelescope/roman_datamodels#428 to pick up required changes.

[schlafly]

LGTM, thanks!