Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename source_detection to source_catalog #428

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Nov 20, 2024

This PR updates this package for the rad changes in spacetelescope/rad#513

See spacetelescope/romancal#1533 for more details.

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.25%. Comparing base (087a60d) to head (7a460e2).
Report is 86 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   97.56%   97.25%   -0.31%     
==========================================
  Files          30       37       +7     
  Lines        2788     3317     +529     
==========================================
+ Hits         2720     3226     +506     
- Misses         68       91      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram force-pushed the source_catalog branch 3 times, most recently from 511a24d to 5a12c18 Compare November 27, 2024 15:28
pyproject.toml Outdated Show resolved Hide resolved
@braingram braingram force-pushed the source_catalog branch 2 times, most recently from 73c346d to 0a2bc94 Compare December 2, 2024 14:10
@braingram braingram marked this pull request as ready for review December 2, 2024 14:15
@braingram braingram requested a review from a team as a code owner December 2, 2024 14:15
@braingram braingram requested a review from PaulHuwe December 2, 2024 14:19
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I see that the regtests are in the companion RCAL ticket.

@braingram braingram enabled auto-merge (squash) December 3, 2024 21:05
@braingram braingram merged commit e43b7fc into spacetelescope:main Dec 3, 2024
14 of 18 checks passed
@braingram braingram deleted the source_catalog branch December 3, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants