-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set DQ of ref pixels to DO_NOT_USE after refpix correction #7017
base: main
Are you sure you want to change the base?
Set DQ of ref pixels to DO_NOT_USE after refpix correction #7017
Conversation
4792cc5
to
8dbe419
Compare
Codecov ReportBase: 78.60% // Head: 78.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #7017 +/- ##
==========================================
+ Coverage 78.60% 78.71% +0.11%
==========================================
Files 455 455
Lines 39148 39431 +283
==========================================
+ Hits 30771 31039 +268
- Misses 8377 8392 +15
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8dbe419
to
938a766
Compare
938a766
to
77e6f86
Compare
77e6f86
to
21fd546
Compare
refpix | ||
------ | ||
|
||
- Set DQ of ref pixels to DO_NOT_USE after `refpix` correction [#7017] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refpix | |
------ | |
- Set DQ of ref pixels to DO_NOT_USE after `refpix` correction [#7017] |
now that #8671 is merged (switching change log handling to towncrier
) this change log entry should be a file in changes/
instead:
echo "Set DQ of ref pixels to ``DO_NOT_USE`` after ``refpix`` correction" > changes/7017.refpix.rst
(new PRs will include instructions on how to do this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ignore this if this PR is no longer active or needed)
Closes #7015
This PR addresses the current fragility of how reference pixels are set to DO_NOT_USE in
calwebb_detector1
. Currently they rely on the GAIN reference file having zeros in the reference pixel locations, and thenramp_fitting
sets those pixels to DO_NOT_USE in the science data DQ.This PR sets the DQ of reference pixels to DO_NOT_USE at the end of the
refpix
step. It does require thatDQInitStep
label these properly as REFERENCE_PIXELS, but this seems to be the case currently for the currently selected MASK reference files for all instruments.Is this the best way to do this? Thoughts?
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR