Change warning type for some kernels. Add unit tests for flux conservation #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 75.29% 75.29%
=======================================
Files 7 7
Lines 344 344
=======================================
Hits 259 259
Misses 85 85 ☔ View full report in Codecov by Sentry. |
nden
reviewed
Feb 22, 2024
drizzle/tests/test_drizzle.py
Outdated
| ) | ||
|
|
||
| @pytest.mark.parametrize( | ||
| 'kernel,conserves', |
There was a problem hiding this comment.
Is conserves used anywhere? Am I missing it?
There was a problem hiding this comment.
good observation. Initially, I was thinking of a different way to design the test but then decided to go with pytest.mark.xfail for non-conserving kernels. Fixed in the next commit
drizzle/tests/test_drizzle.py
Outdated
| ), | ||
| ], | ||
| ) | ||
| def test_flux_conservation_distorted(kernel, conserves): |
Nothing for now. It was deprecated in #140. This PR simply adds unit tests to test flux (non-)conservation. |
nden
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests that verify that "square", "turbo", and "point" kernels do conserve flux.
It also modifies the warning type for the "non flux conserving" kernels from
DeprecationWarningtoWarning.