Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Drizzle Kernels: gaussian, lanczos, and tophat #1751

Closed
stscijgbot-hstdp opened this issue Feb 22, 2024 · 2 comments · Fixed by #1786
Closed

Remove Drizzle Kernels: gaussian, lanczos, and tophat #1751

stscijgbot-hstdp opened this issue Feb 22, 2024 · 2 comments · Fixed by #1786

Comments

@stscijgbot-hstdp
Copy link
Collaborator

Issue HLA-1216 was created on JIRA by Steve Goldman:

It was found that several kernels that are available options in drizzlepac do not conserve flux and should be removed as options. This change is related to recent changes in the standalone drizzle package and Jira ticket AL-774.

 

The kernels that should be removed are gaussian, lanczos, and tophat. What should remain is point, square, and turbo. 

 

The documentation as well as drizzle unit test also need to be updated. 

@stscijgbot-hstdp
Copy link
Collaborator Author

stscijgbot-hstdp commented Apr 10, 2024

Comment by Steve Goldman on JIRA:

A note from mihai:

I know that people use those kernels. Tophat simply does not work correctly (and likely it never did before) and it will not be fixed. It has to go.
However, technically the others are OK in the sense they don't produce outrageous results. For the very least it should be documented and/or software should issue a warning about flux not being conserved ```
After discussions with folks on the drizzle_updates slack channel, it was decided that I will add warnings forlanczosandgaussianthat we cannot guarantee that they are conserving flux, but leave them as options.

I also removedtophatas an option.  

@stscijgbot-hstdp
Copy link
Collaborator Author

Comment by Steve Goldman on JIRA:

Closed by PR-1786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant