Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parallel modes file to pipeline #15719

Merged

Conversation

cyw233
Copy link
Contributor

@cyw233 cyw233 commented Nov 24, 2024

Description of PR

Add parallel modes file option to pipeline so users can customize the parallel modes by using their own file in the test_parallel_modes/ folder.

Summary:
Fixes # (issue) Microsoft ADO 29867650

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

We want users to be able to customize the parallel modes file, so we added the parallel modes file option to the pipeline.

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@@ -119,6 +119,10 @@ parameters:
type: string
default: ""

- name: PARALLEL_MODES_FILE
type: string
default: "default.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to leave this parameter empty, as parallel run is disabled by default and we already have a default value in test_plan.py and elastictest. Additionally, consider adding a comment for clarification if necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Let me fix this

Copy link
Contributor

@lerry-lee lerry-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyw233 cyw233 force-pushed the add-parallel-modes-file-to-pipeline branch from e9a82a4 to b00fe60 Compare December 17, 2024 05:55
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan yejianquan merged commit 67c82cf into sonic-net:master Dec 18, 2024
16 checks passed
@mssonicbld
Copy link
Collaborator

@cyw233 PR conflicts with 202405 branch

@cyw233
Copy link
Contributor Author

cyw233 commented Dec 18, 2024

@cyw233 PR conflicts with 202405 branch

No need to cherry-pick the entire PR to feature branch. We only need to cherry-pick the parallel mode files to 202405: #16134

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 3, 2025
Description of PR
Add parallel modes file option to pipeline so users can customize the parallel modes by using their own file in the test_parallel_modes/ folder.

Summary:
Fixes # (issue) Microsoft ADO 29867650

Approach
What is the motivation for this PR?
We want users to be able to customize the parallel modes file, so we added the parallel modes file option to the pipeline.

co-authorized by: [email protected]
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16317

@cyw233
Copy link
Contributor Author

cyw233 commented Jan 3, 2025

Cherry-pick the parallel mode files to 202411: #16323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants