-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add parallel modes file to pipeline #15719
feat: add parallel modes file to pipeline #15719
Conversation
@@ -119,6 +119,10 @@ parameters: | |||
type: string | |||
default: "" | |||
|
|||
- name: PARALLEL_MODES_FILE | |||
type: string | |||
default: "default.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is recommended to leave this parameter empty, as parallel run is disabled by default and we already have a default value in test_plan.py and elastictest. Additionally, consider adding a comment for clarification if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Let me fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e9a82a4
to
b00fe60
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@cyw233 PR conflicts with 202405 branch |
Description of PR Add parallel modes file option to pipeline so users can customize the parallel modes by using their own file in the test_parallel_modes/ folder. Summary: Fixes # (issue) Microsoft ADO 29867650 Approach What is the motivation for this PR? We want users to be able to customize the parallel modes file, so we added the parallel modes file option to the pipeline. co-authorized by: [email protected]
Cherry-pick PR to 202411: #16317 |
Cherry-pick the parallel mode files to 202411: #16323 |
Description of PR
Add parallel modes file option to pipeline so users can customize the parallel modes by using their own file in the
test_parallel_modes/
folder.Summary:
Fixes # (issue) Microsoft ADO 29867650
Type of change
Back port request
Approach
What is the motivation for this PR?
We want users to be able to customize the parallel modes file, so we added the parallel modes file option to the pipeline.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation