refactor: enhance override config masic test #16226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
9 tasks
yejianquan
reviewed
Jan 2, 2025
|
@cyw233 Have we tested it on the non-chassis devices? |
Can confirm the change will not cause any regression on multi-asic T1 device: https://elastictest.org/scheduler/testplan/67763b01b9fbfafb6a51c1b5 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 2, 2025
Description of PR Enhance the override_config_table/test_override_config_table_masic.py to make it compatible with the parallel run infra. Summary: Fixes # (issue) Microsoft ADO 30056122 Approach What is the motivation for this PR? We wanted to enable parallel run for override_config_table/test_override_config_table_masic.py, so we need to deprecate enum_upstream_dut_hostname. How did you do it? How did you verify/test it? I ran the updated code and can confirm it's working as expected. co-authorized by: [email protected]
|
Cherry-pick PR to 202411: #16310 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 2, 2025
Description of PR Enhance the override_config_table/test_override_config_table_masic.py to make it compatible with the parallel run infra. Summary: Fixes # (issue) Microsoft ADO 30056122 Approach What is the motivation for this PR? We wanted to enable parallel run for override_config_table/test_override_config_table_masic.py, so we need to deprecate enum_upstream_dut_hostname. How did you do it? How did you verify/test it? I ran the updated code and can confirm it's working as expected. co-authorized by: [email protected]
|
Cherry-pick PR to 202405: #16311 |
This was referenced Jan 2, 2025
mssonicbld
pushed a commit
that referenced
this pull request
Jan 3, 2025
Description of PR Enhance the override_config_table/test_override_config_table_masic.py to make it compatible with the parallel run infra. Summary: Fixes # (issue) Microsoft ADO 30056122 Approach What is the motivation for this PR? We wanted to enable parallel run for override_config_table/test_override_config_table_masic.py, so we need to deprecate enum_upstream_dut_hostname. How did you do it? How did you verify/test it? I ran the updated code and can confirm it's working as expected. co-authorized by: [email protected]
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
yejianquan
pushed a commit
that referenced
this pull request
Jan 3, 2025
Description of PR Enable parallel run for override_config_table/test_override_config_table_masic.py in 202405 Summary: Fixes # (issue) Microsoft ADO 30056122 Approach What is the motivation for this PR? Previously we disabled parallel run for override_config_table/test_override_config_table_masic.py in 202405 as it's not compatible with the existing infra. Now this test has been enhanced in #16226 so we can enable parallel run for it. co-authorized by: [email protected]
mssonicbld
pushed a commit
that referenced
this pull request
Jan 3, 2025
Description of PR Enhance the override_config_table/test_override_config_table_masic.py to make it compatible with the parallel run infra. Summary: Fixes # (issue) Microsoft ADO 30056122 Approach What is the motivation for this PR? We wanted to enable parallel run for override_config_table/test_override_config_table_masic.py, so we need to deprecate enum_upstream_dut_hostname. How did you do it? How did you verify/test it? I ran the updated code and can confirm it's working as expected. co-authorized by: [email protected]
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Enhance the
override_config_table/test_override_config_table_masic.pyto make it compatible with the parallel run infra.Summary:
Fixes # (issue) Microsoft ADO 30056122
Type of change
Back port request
Approach
What is the motivation for this PR?
We wanted to enable parallel run for
override_config_table/test_override_config_table_masic.py, so we need to deprecateenum_upstream_dut_hostname.How did you do it?
How did you verify/test it?
I ran the updated code and can confirm it's working as expected.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation