[dualtor] Fix snmp/* tests failure on fixture teardown #15529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR#15359 has introduced a "yield" statement inside the for loop of duthosts which is causing fixture teardown to fail with "Failed: fixture function has more than one 'yield'" message. Fix is to move "yield" statement out of this for loop and do config rollback in a seperate for loop of duthosts.
This was referenced Nov 13, 2024
|
LGTM |
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
Approach What is the motivation for this PR? sonic-net#15359 has introduced a "yield" statement inside the for loop of duthosts which is causing fixture teardown to fail with Failed: fixture function has more than one 'yield' message. How did you do it? Move "yield" statement out of this for loop of duthosts and do config rollback in a seperate for loop of duthosts. How did you verify/test it? Ran tests under snmp folder and tests are passing on Arista-7260CX3-D108C8 platform. Any platform specific information?
|
Cherry-pick PR to 202405: #15575 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 15, 2024
Approach What is the motivation for this PR? #15359 has introduced a "yield" statement inside the for loop of duthosts which is causing fixture teardown to fail with Failed: fixture function has more than one 'yield' message. How did you do it? Move "yield" statement out of this for loop of duthosts and do config rollback in a seperate for loop of duthosts. How did you verify/test it? Ran tests under snmp folder and tests are passing on Arista-7260CX3-D108C8 platform. Any platform specific information?
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
Approach What is the motivation for this PR? sonic-net#15359 has introduced a "yield" statement inside the for loop of duthosts which is causing fixture teardown to fail with Failed: fixture function has more than one 'yield' message. How did you do it? Move "yield" statement out of this for loop of duthosts and do config rollback in a seperate for loop of duthosts. How did you verify/test it? Ran tests under snmp folder and tests are passing on Arista-7260CX3-D108C8 platform. Any platform specific information?
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
Approach What is the motivation for this PR? sonic-net#15359 has introduced a "yield" statement inside the for loop of duthosts which is causing fixture teardown to fail with Failed: fixture function has more than one 'yield' message. How did you do it? Move "yield" statement out of this for loop of duthosts and do config rollback in a seperate for loop of duthosts. How did you verify/test it? Ran tests under snmp folder and tests are passing on Arista-7260CX3-D108C8 platform. Any platform specific information?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Move
yieldstatement out of for loop in snmp fixturesetup_check_snmp_readyFixes # https://github.com/aristanetworks/sonic-qual.msft/issues/307
Type of change
Back port request
Approach
What is the motivation for this PR?
#15359 has introduced a "yield" statement inside the for loop of duthosts which is causing fixture teardown to fail with
Failed: fixture function has more than one 'yield'message.How did you do it?
Move "yield" statement out of this for loop of duthosts and do config rollback in a seperate for loop of duthosts.
How did you verify/test it?
Ran tests under
snmpfolder and tests are passing onArista-7260CX3-D108C8platform.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation