[PR:14926] Configuring Community SNMP Credentials for SNMP TCs #15359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description of PR Summary: The PR contains changes to snmp/conftest.py with logic to configure snmp credentials stored in snmp.yml for every host before running any test script. Approach What is the motivation for this PR? If credentials in snmp.yml isn't configured, then the changes in PR configures them before running the tests and restores the original configuration after the TC execution. How did you do it? snmp/conftest.py will now copy the snmp.yml from DUT to UCS (if DUT has snmp.yml) & then it will configure the SNMP credentials for every host via sudo config snmp command. The logic it configures is same as in snmp_yml_to_configdb.py script; where it checks whether the credentials in yml are configured in config_db or not, if the keys are configured but the values are different / the keys are not configured - then it will configure them. Before the test script execution, SNMP is configured, once the execution completes, it reverts the configuration that existed before. How did you verify/test it? Run changes with 202405 image on a T0 setup without snmp credentials configured / with different credentials configured in image and snmp tests passed as expected in all scenarios. co-authorized by: [email protected]
9 tasks
|
Hi @agadia-cisco , test is reporting error, more than one yield in a fixture. |
|
@vperumal for viz |
8 tasks
|
PR #15529 will fix the issue. |
StormLiangMS
pushed a commit
that referenced
this pull request
Nov 15, 2024
Approach What is the motivation for this PR? #15359 has introduced a "yield" statement inside the for loop of duthosts which is causing fixture teardown to fail with Failed: fixture function has more than one 'yield' message. How did you do it? Move "yield" statement out of this for loop of duthosts and do config rollback in a seperate for loop of duthosts. How did you verify/test it? Ran tests under snmp folder and tests are passing on Arista-7260CX3-D108C8 platform. Any platform specific information?
|
this cause regression, and fixed in https://github.com/sonic-net/sonic-mgmt/pull/15359/files |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
Approach What is the motivation for this PR? sonic-net#15359 has introduced a "yield" statement inside the for loop of duthosts which is causing fixture teardown to fail with Failed: fixture function has more than one 'yield' message. How did you do it? Move "yield" statement out of this for loop of duthosts and do config rollback in a seperate for loop of duthosts. How did you verify/test it? Ran tests under snmp folder and tests are passing on Arista-7260CX3-D108C8 platform. Any platform specific information?
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 15, 2024
Approach What is the motivation for this PR? #15359 has introduced a "yield" statement inside the for loop of duthosts which is causing fixture teardown to fail with Failed: fixture function has more than one 'yield' message. How did you do it? Move "yield" statement out of this for loop of duthosts and do config rollback in a seperate for loop of duthosts. How did you verify/test it? Ran tests under snmp folder and tests are passing on Arista-7260CX3-D108C8 platform. Any platform specific information?
9 tasks
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
Approach What is the motivation for this PR? sonic-net#15359 has introduced a "yield" statement inside the for loop of duthosts which is causing fixture teardown to fail with Failed: fixture function has more than one 'yield' message. How did you do it? Move "yield" statement out of this for loop of duthosts and do config rollback in a seperate for loop of duthosts. How did you verify/test it? Ran tests under snmp folder and tests are passing on Arista-7260CX3-D108C8 platform. Any platform specific information?
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
Approach What is the motivation for this PR? sonic-net#15359 has introduced a "yield" statement inside the for loop of duthosts which is causing fixture teardown to fail with Failed: fixture function has more than one 'yield' message. How did you do it? Move "yield" statement out of this for loop of duthosts and do config rollback in a seperate for loop of duthosts. How did you verify/test it? Ran tests under snmp folder and tests are passing on Arista-7260CX3-D108C8 platform. Any platform specific information?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: The PR contains changes to
snmp/conftest.pywith logic to configuresnmpcredentials stored insnmp.ymlfor every host before running any test script.Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
If credentials in
snmp.ymlisn't configured, then the changes in PR configures them before running the tests and restores the original configuration after the TC execution.How did you do it?
snmp/conftest.pywill now copy thesnmp.ymlfrom DUT to UCS (if DUT hassnmp.yml) & then it will configure the SNMP credentials for every host viasudo config snmpcommand. The logic it configures is same as insnmp_yml_to_configdb.pyscript; where it checks whether the credentials in yml are configured inconfig_dbor not, if the keys are configured but the values are different / the keys are not configured - then it will configure them. Before the test script execution, SNMP is configured, once the execution completes, it reverts the configuration that existed before.How did you verify/test it?
202405image on a T0 setup withoutsnmpcredentials configured / with different credentials configured in image andsnmptests passed as expected in all scenarios.