-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buffer queue counters test case to telemetry test #12735
Conversation
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
@qiluo-msft @zbud-msft Can you please help review this PR? |
@arfeigin Could you check the test failure? |
/azp run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run Azure.sonic-mgmt |
Commenter does not have sufficient privileges for PR 12735 in repo sonic-net/sonic-mgmt |
/azpw run Azure.sonic-mgmt |
@qiluo-msft , Can you please approve and merge ? |
@qiluo-msft Is this PR required for other release branch? |
* Add buffer queue counters test case to telemetry test
Cherry-pick PR to 202405: #13207 |
* Add buffer queue counters test case to telemetry test
@arfeigin Please disable loganalyzer for new testcase, internal tests for this testcase are failing due to loganalyzer. |
Description of PR
This test is checking that the number of buffer queue counters from telemetry point of view is inline when using create_only_config_db_counters optimization.
Summary:
Accompanies "Fix SNMP dropping some of the queue counter when create_only_config_db_buffers is set to true" (sonic-net/sonic-snmpagent#303) which fixes the issue: "The feature "polling only configured ports buffer queue" will break SNMP" (sonic-net/sonic-buildimage#17448).
Accompanies "Test polling only configured buffer queue counters" #11941
Type of change
Back port request
Approach
What is the motivation for this PR?
To enhance the bug fix mentioned above, solving an issue with buffer queue counters optimization.
How did you do it?
How did you verify/test it?
Run the test multiple times on various setups.
Any platform specific information?
Supported testbed topology if it's a new test case?
Any
Documentation