Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Create counters only for configured buffer objects on SN5400 #19152

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented May 31, 2024

Why I did it

Create counters for configured buffer objects only on ACS-SN5400
We did this for all generic SKUs but missed it for ACS-SN5400

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311
  • 202405

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@stephenxs stephenxs force-pushed the create-counter-for-configured-buffer-only-5400 branch from 3d766fc to 4460d27 Compare June 6, 2024 23:13
@stephenxs stephenxs marked this pull request as ready for review June 7, 2024 01:38
@stephenxs stephenxs changed the title Create counters only for configured buffer objects on SN5400 [Mellanox] Create counters only for configured buffer objects on SN5400 Jun 7, 2024
@stephenxs stephenxs requested a review from DavidZagury June 7, 2024 01:40
@bingwang-ms
Copy link
Contributor

Hi @stephenxs , will this test sonic-net/sonic-mgmt#12735 still pass with this change?

@stephenxs
Copy link
Collaborator Author

Hi @stephenxs , will this test sonic-net/sonic-mgmt#12735 still pass with this change?

Hi @bingwang-ms
It should. I believe that change (sonic-mgmt#12735) was introduced exactly to overcome the situation where create_only_config_db_buffers is defined.

@bingwang-ms
Copy link
Contributor

@yxieca Can you please help merge this PR?

@yxieca yxieca merged commit 1e4789b into sonic-net:master Jun 24, 2024
20 checks passed
@stephenxs stephenxs deleted the create-counter-for-configured-buffer-only-5400 branch June 24, 2024 01:40
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 24, 2024
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #19378

yxieca pushed a commit that referenced this pull request Jun 24, 2024
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 2, 2024
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #19798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants