Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.4] Fix(promotions): Validate benefits on save #6023

Merged
merged 2 commits into from
Dec 6, 2024

Add status code to benefits controller action

3683320
Select commit
Loading
Failed to load commit list.
Merged

[v4.4] Fix(promotions): Validate benefits on save #6023

Add status code to benefits controller action
3683320
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 6, 2024 in 1s

25.00% of diff hit (target 87.81%)

View this Pull Request on Codecov

25.00% of diff hit (target 87.81%)

Annotations

Check warning on line 22 in promotions/lib/controllers/backend/solidus_promotions/admin/benefits_controller.rb

See this annotation in the file changed.

@codecov codecov / codecov/patch

promotions/lib/controllers/backend/solidus_promotions/admin/benefits_controller.rb#L22 

Added line #L22 was not covered by tests

Check warning on line 31 in promotions/lib/controllers/backend/solidus_promotions/admin/benefits_controller.rb

See this annotation in the file changed.

@codecov codecov / codecov/patch

promotions/lib/controllers/backend/solidus_promotions/admin/benefits_controller.rb#L31 

Added line #L31 was not covered by tests

Check warning on line 42 in promotions/lib/controllers/backend/solidus_promotions/admin/benefits_controller.rb

See this annotation in the file changed.

@codecov codecov / codecov/patch

promotions/lib/controllers/backend/solidus_promotions/admin/benefits_controller.rb#L42 

Added line #L42 was not covered by tests
View more details on Codecov