[v4.4] Fix(promotions): Validate benefits on save #6023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
On Slack, we got a report that the tiered percent calculator wasn't converting its tiers to BigDecimal when being first created. Since this conversion happens `before_validation`, we should not turn validation off in this controller. Specs still run through. (cherry picked from commit 42d65fd)
These should help Turbo interpret what's going on. (cherry picked from commit d98ec79)
github-actions
bot
added
the
changelog:solidus_promotions
tvdeyen
approved these changes
Dec 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4.4 #6023 +/- ##
==========================================
+ Coverage 87.81% 89.45% +1.63%
==========================================
Files 476 782 +306
Lines 11658 17993 +6335
==========================================
+ Hits 10238 16096 +5858
- Misses 1420 1897 +477 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.4:Questions ?
Please refer to the Backport tool documentation