Fix(promotions): Validate benefits on save #5981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Slack, we got a report that the tiered percent calculator wasn't converting its tiers to BigDecimal when being first created. Since this conversion happens `before_validation`, we should not turn validation off in this controller. Specs still run through.
github-actions
bot
added
the
changelog:solidus_promotions
tvdeyen
approved these changes
Dec 3, 2024
adammathys
approved these changes
Dec 3, 2024
boomer196
reviewed
Dec 3, 2024
promotions/lib/controllers/backend/solidus_promotions/admin/benefits_controller.rb
Show resolved
Hide resolved
These should help Turbo interpret what's going on.
mamhoff
force-pushed
the
tiered-percent-fix
branch
from
37dd726 to
d98ec79
Compare
boomer196
reviewed
Dec 3, 2024
promotions/lib/controllers/backend/solidus_promotions/admin/benefits_controller.rb
Show resolved
Hide resolved
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Dec 4, 2024
In solidusio#5981, we accidentally set this error render to a response code 422.
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Dec 4, 2024
In solidusio#5981, we accidentally set this render to a response code 422. Since it's really the initial render of the form, it should stay a 200.
|
Backport after #6016 |
tvdeyen
added
backport-v4.4
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Slack, we got a report that the tiered percent calculator wasn't converting its tiers to BigDecimal when being first created. Since this conversion happens
before_validation, we should not turn validation off in this controller.Specs still run through, and I smoke-tested this change locally.