Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.1] Fix dummy app database.yml for ENV[DB] = sqlite3 #5622

Closed
wants to merge 1 commit into from
Closed

[v4.1] Fix dummy app database.yml for ENV[DB] = sqlite3 #5622

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

Backport

This will backport the following commits from v4.2 to v4.1:

Questions ?

Please refer to the Backport tool documentation

@mamhoff
Fix dummy app database.yml for ENV[DB] = sqlite3
f773228 
This is the same fix as #5613, but this time for the dummy app
`database.yml` template rather than for the install generator.

I've now also tested this locally, and it seems to work.

(cherry picked from commit 0a8c2b8)
@github-actions github-actions bot requested a review from a team as a code owner January 24, 2024 11:40
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jan 24, 2024
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Merged
3 tasks
@spaghetticode
Copy link
Member

Closing in favor of #5617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adammathys adammathys adammathys approved these changes

Assignees
No one assigned
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaghetticode @adammathys @mamhoff