Fix dummy app database.yml for ENV[DB] = sqlite3 #5619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same fix as solidusio#5613, but this time for the dummy app `database.yml` template rather than for the install generator. I've now also tested this locally, and it seems to work.
github-actions
bot
added
the
changelog:solidus_core
spaghetticode
added
backport-v3.4
This was referenced Jan 24, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the same fix as #5613, but this time for the dummy app
database.ymltemplate rather than for the install generator. #5613 did not actually fix the test builds on its own: https://app.circleci.com/pipelines/github/solidusio-contrib/solidus_reviews/356/workflows/81386dc4-9a26-404b-a082-dc49cf25a46b/jobs/858I've now also tested this locally, and it seems to work.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: