Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolidusAdmin: Extract page layout helpers #5445

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

elia
Copy link
Member

@elia elia commented Oct 19, 2023

Summary

Extract some helpers that can be used to build page layouts, this is the first step in sharing this code, we're looking toward a better solution for the future (e.g. one or multiple components, or prebuilt TW classes) but it's early to tell which will be the best approach.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia force-pushed the elia/admin/page-helpers branch from f18cf56 to 510878d Compare October 19, 2023 13:28
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #5445 (510878d) into main (de6030b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5445      +/-   ##
==========================================
+ Coverage   88.89%   88.91%   +0.02%     
==========================================
  Files         612      614       +2     
  Lines       14800    14827      +27     
==========================================
+ Hits        13156    13183      +27     
  Misses       1644     1644              
Files Coverage Δ
...pp/components/solidus_admin/layout/page_helpers.rb 100.00% <100.00%> (ø)
...p/components/solidus_admin/orders/new/component.rb 100.00% <100.00%> (ø)
...mponents/solidus_admin/products/index/component.rb 91.17% <100.00%> (+0.26%) ⬆️
...omponents/solidus_admin/products/show/component.rb 78.57% <100.00%> (+1.64%) ⬆️
...onents/solidus_admin/ui/table/toolbar/component.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review October 19, 2023 13:46
@elia elia requested a review from a team as a code owner October 19, 2023 13:46
@elia elia requested a review from rainerdema October 19, 2023 13:46
@elia elia merged commit e1f59e2 into main Oct 23, 2023
4 checks passed
@elia elia deleted the elia/admin/page-helpers branch October 23, 2023 09:28
rainerdema added a commit to nebulab/solidus that referenced this pull request Oct 23, 2023
Eliminated an unnecessary double rendering of the feedback component in both
the Orders and Products tables.
This change leverages the `page_header_actions` helper, aligning with the
updates in solidusio#5445.
rainerdema added a commit to nebulab/solidus that referenced this pull request Oct 24, 2023
Eliminated an unnecessary double rendering of the feedback component in both
the Orders and Products tables.
This change leverages the `page_header_actions` helper, aligning with the
updates in solidusio#5445.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants