Skip to content

Commit

Permalink
Remove redundant feedback component in Orders & Products tables
Browse files Browse the repository at this point in the history
Eliminated an unnecessary double rendering of the feedback component in both
the Orders and Products tables.
This change leverages the `page_header_actions` helper, aligning with the
updates in solidusio#5445.
  • Loading branch information
rainerdema committed Oct 23, 2023
1 parent 4c51076 commit 3f18f81
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
</h1>

<div class="ml-auto flex gap-2 items-center">
<%= render component("feedback").new %>
<%= render component("ui/button").new(
tag: :a,
text: t('.create_order'),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<%= page_header_title t(".create_order") %>

<%= page_header_actions do %>
<%= render component("feedback").new %>
<%= render component("ui/button").new(tag: :button, scheme: :secondary, text: t(".discard"), form: form_id) %>
<%= render component("ui/button").new(tag: :button, text: t(".save"), form: form_id) %>
<% end %>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<%= page_header do %>
<%= page_header_title title %>
<%= page_header_actions do %>
<%= render component("feedback").new %>
<%= render component("ui/button").new(
tag: :a,
text: t('.add_product'),
Expand Down

0 comments on commit 3f18f81

Please sign in to comment.