Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the content navbar being hidden under the navbar when the window is narrow #5423

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

elia
Copy link
Member

@elia elia commented Oct 6, 2023

Summary

The new navbar doesn't support hiding and we shouldn't execute that code if it's in use.

image

cc @filippoliverani

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia requested a review from rainerdema October 6, 2023 16:16
@elia elia self-assigned this Oct 6, 2023
@elia elia requested a review from a team as a code owner October 6, 2023 16:16
@elia elia added the backport-v4.2 Backport this pull-request to v4.2 label Oct 6, 2023
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #5423 (039fe9c) into main (bd404fe) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5423   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files         607      607           
  Lines       14748    14748           
=======================================
  Hits        13105    13105           
  Misses       1643     1643           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👏

@elia elia merged commit c64e9fd into main Oct 6, 2023
6 checks passed
@elia elia deleted the elia/stop-auto-hiding-the-navbar branch October 6, 2023 16:55
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

💚 All backports created successfully

Status Branch Result
v4.2

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@elia elia changed the title Skip all the navbar hiding logic when using the new version Fix the content navbar being hidden under the navbar when the window is narrow Oct 6, 2023
@elia elia requested review from rainerdema and removed request for rainerdema October 12, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.2 Backport this pull-request to v4.2 changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants