Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the order tabs are not collapsed into a drop down #315

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

elia
Copy link
Member

@elia elia commented Oct 4, 2023

Summary

The "Payments" tab in the admin order page was collapsed if the browser width was too narrow.
Also required solidusio/solidus#5423 to be merged to fix content ending up under the sidebar.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Oct 4, 2023
@elia elia force-pushed the elia/post-release-updates branch from a50e349 to 0ac58bd Compare October 6, 2023 10:17
@elia elia force-pushed the elia/post-release-updates branch 3 times, most recently from ff8c150 to 9ed80fe Compare October 6, 2023 16:58
@elia elia requested a review from rainerdema October 6, 2023 17:49
@elia elia marked this pull request as ready for review October 6, 2023 17:49
@elia elia force-pushed the elia/post-release-updates branch from 9ed80fe to a65376b Compare October 6, 2023 17:59
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #315 (a65376b) into main (90894c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          31       31           
  Lines         563      563           
=======================================
  Hits          561      561           
  Misses          2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia merged commit 2573352 into main Oct 9, 2023
2 checks passed
@elia elia deleted the elia/post-release-updates branch October 9, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants