Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Separate authorization from authentication #5390

Merged
merged 3 commits into from
Sep 21, 2023

Move authorization checks outside of the backend "auth" adapter

3dbae49
Select commit
Loading
Failed to load commit list.
Merged

[admin] Separate authorization from authentication #5390

Move authorization checks outside of the backend "auth" adapter
3dbae49
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Sep 20, 2023 in 0s

88.79% (+0.00%) compared to 7f55370

View this Pull Request on Codecov

88.79% (+0.00%) compared to 7f55370

Details

Codecov Report

Merging #5390 (3dbae49) into nebulab/admin (7f55370) will increase coverage by 0.00%.
The diff coverage is 90.90%.

@@              Coverage Diff               @@
##           nebulab/admin    #5390   +/-   ##
==============================================
  Coverage          88.78%   88.79%           
==============================================
  Files                606      607    +1     
  Lines              14670    14680   +10     
==============================================
+ Hits               13025    13035   +10     
  Misses              1645     1645           
Files Changed Coverage Δ
...s/solidus_admin/authentication_adapters/backend.rb 84.61% <84.61%> (ø)
.../solidus_admin/controller_helpers/authorization.rb 92.85% <92.85%> (ø)
...p/controllers/solidus_admin/accounts_controller.rb 100.00% <100.00%> (ø)
...n/app/controllers/solidus_admin/base_controller.rb 100.00% <100.00%> (ø)
...solidus_admin/controller_helpers/authentication.rb 100.00% <100.00%> (ø)
admin/lib/solidus_admin/preview.rb 93.33% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more