Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Separate authorization from authentication #5390

Merged
merged 3 commits into from
Sep 21, 2023

Move authorization checks outside of the backend "auth" adapter

3dbae49
Select commit
Loading
Failed to load commit list.
Merged

[admin] Separate authorization from authentication #5390

Move authorization checks outside of the backend "auth" adapter
3dbae49
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/patch succeeded Sep 20, 2023 in 0s

90.90% of diff hit (target 88.78%)

View this Pull Request on Codecov

90.90% of diff hit (target 88.78%)

Annotations

Check warning on line 20 in admin/app/controllers/solidus_admin/authentication_adapters/backend.rb

See this annotation in the file changed.

@codecov codecov / codecov/patch

admin/app/controllers/solidus_admin/authentication_adapters/backend.rb#L20

Added line #L20 was not covered by tests

Check warning on line 24 in admin/app/controllers/solidus_admin/authentication_adapters/backend.rb

See this annotation in the file changed.

@codecov codecov / codecov/patch

admin/app/controllers/solidus_admin/authentication_adapters/backend.rb#L24

Added line #L24 was not covered by tests

Check warning on line 26 in admin/app/controllers/solidus_admin/controller_helpers/authorization.rb

See this annotation in the file changed.

@codecov codecov / codecov/patch

admin/app/controllers/solidus_admin/controller_helpers/authorization.rb#L26

Added line #L26 was not covered by tests