Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Misc. bugfixes #5386

Merged
merged 4 commits into from
Sep 19, 2023
Merged

[admin] Misc. bugfixes #5386

merged 4 commits into from
Sep 19, 2023

Conversation

elia
Copy link
Member

@elia elia commented Sep 19, 2023

Summary

Minor fixes noticed while working on #5385.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia requested a review from rainerdema September 19, 2023 11:29
@elia elia requested a review from a team as a code owner September 19, 2023 11:29
@elia elia self-assigned this Sep 19, 2023
@elia elia mentioned this pull request Sep 19, 2023
3 tasks
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #5386 (a16647b) into nebulab/admin (74dcc5f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           nebulab/admin    #5386      +/-   ##
=================================================
+ Coverage          88.86%   88.87%   +0.01%     
=================================================
  Files                615      615              
  Lines              14860    14861       +1     
=================================================
+ Hits               13205    13208       +3     
+ Misses              1655     1653       -2     
Files Changed Coverage Δ
...components/solidus_admin/ui/toggletip/component.rb 100.00% <100.00%> (ø)
...p/controllers/solidus_admin/products_controller.rb 100.00% <100.00%> (+5.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia merged commit f4c0dc2 into nebulab/admin Sep 19, 2023
@elia elia deleted the elia/admin/bug-fixes branch September 19, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants