Merge pull request #5386 from solidusio/elia/admin/bug-fixes

[admin] Misc. bugfixes
solidusio · Sep 19, 2023 · f4c0dc2 · f4c0dc2
2 parents 74dcc5f + a16647b
commit f4c0dc2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/admin/app/components/solidus_admin/ui/table/component.html.erb b/admin/app/components/solidus_admin/ui/table/component.html.erb
@@ -87,7 +87,7 @@
     </div>
   </div>
 
-  <div class="<%= toolbar_classes %>" data-<%= stimulus_id %>-target="batchToolbar" aria-role="toolbar" aria-label="<%= t(".batch_actions") %>">
+  <div class="<%= toolbar_classes %>" data-<%= stimulus_id %>-target="batchToolbar" role="toolbar" aria-label="<%= t(".batch_actions") %>">
     <%= form_tag '', id: batch_actions_form_id %>
     <% @batch_actions.each do |batch_action| %>
       <%= render_batch_action_button(batch_action) %>

diff --git a/admin/app/components/solidus_admin/ui/toggletip/component.rb b/admin/app/components/solidus_admin/ui/toggletip/component.rb
@@ -61,7 +61,7 @@ class SolidusAdmin::UI::Toggletip::Component < SolidusAdmin::BaseComponent
   # @param theme [Symbol] The theme of the toggletip. Defaults to `:light`. See
   #   `THEMES` for available options.
   def initialize(text:, position: :down, theme: :light, **attributes)
-    @text = text || guide
+    @text = text
     @position = position
     @theme = theme
     @attributes = attributes

diff --git a/admin/app/controllers/solidus_admin/products_controller.rb b/admin/app/controllers/solidus_admin/products_controller.rb
@@ -26,7 +26,10 @@ def update
         redirect_to action: :show, status: :see_other
       else
         flash.now[:error] = @product.errors.full_messages.join(", ")
-        render action: :show, status: :unprocessable_entity
+
+        respond_to do |format|
+          format.html { render component('products/show').new(product: @product), status: :unprocessable_entity }
+        end
       end
     end
 

diff --git a/admin/spec/features/product_spec.rb b/admin/spec/features/product_spec.rb
@@ -40,6 +40,10 @@
     within('header') { click_button "Save" }
 
     expect(page).to have_content("Just a product (updated)")
+    fill_in "Name", with: ""
+    within('header') { click_button "Save" }
+
+    expect(page).to have_content("Name can't be blank")
     expect(page).to be_axe_clean
   end
 end