Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pr 799 #801

Merged
merged 8 commits into from
May 11, 2023
Merged

Test pr 799 #801

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7abca2b
Covnert newtypes to type aliases
StefanUlbrich Apr 21, 2023
45a0bdf
Remove commented code
StefanUlbrich Apr 21, 2023
31826fb
Remove newlines
StefanUlbrich Apr 21, 2023
6a77cfc
Merge branch 'main' into test_pr_799
sfc-gh-aalam Apr 22, 2023
cf19c24
give credits to stefan
sfc-gh-aalam Apr 23, 2023
5ae236a
Merge branch 'main' into test_pr_799
sfc-gh-aalam Apr 25, 2023
9e74af6
Merge branch 'main' into test_pr_799
sfc-gh-aalam Apr 27, 2023
b58af36
Update CHANGELOG.md
sfc-gh-aalam Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,15 @@
## 1.5.0 (TBD)

### New Features

- Added support for new functions in `snowflake.snowpark.functions`:
- `array_generate_range`
- `sequence`

### Bug Fixes

- Fixed type hint declaration for custom types - `ColumnOrName`, `ColumnOrLiteralStr`, `ColumnOrSqlExpr`, `LiteralType` and `ColumnOrLiteral` that were breaking `mypy` checks. Contributor: @StefanUlbrich.

sfc-gh-aalam marked this conversation as resolved.
Show resolved Hide resolved
## 1.4.0 (2023-04-24)

### New Features
Expand Down
16 changes: 5 additions & 11 deletions src/snowflake/snowpark/_internal/type_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,14 +622,8 @@ def type_string_to_type_object(type_str: str) -> DataType:


# Type hints
ColumnOrName = NewType("ColumnOrName", Union["snowflake.snowpark.column.Column", str])
ColumnOrLiteralStr = NewType(
"ColumnOrLiteralStr", Union["snowflake.snowpark.column.Column", str]
)
ColumnOrSqlExpr = NewType(
"ColumnOrSqlExpr", Union["snowflake.snowpark.column.Column", str]
)
LiteralType = NewType("LiteralType", Union[VALID_PYTHON_TYPES_FOR_LITERAL_VALUE])
ColumnOrLiteral = NewType(
"ColumnOrLiteral", Union["snowflake.snowpark.column.Column", LiteralType]
)
ColumnOrName = Union["snowflake.snowpark.column.Column", str]
ColumnOrLiteralStr = Union["snowflake.snowpark.column.Column", str]
ColumnOrSqlExpr = Union["snowflake.snowpark.column.Column", str]
LiteralType = Union[VALID_PYTHON_TYPES_FOR_LITERAL_VALUE]
ColumnOrLiteral = Union["snowflake.snowpark.column.Column", LiteralType]