Test pr 799 #801
Merged
Test pr 799 #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #801 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 49 49
Lines 8403 8403
Branches 1425 1425
=======================================
Hits 8243 8243
Misses 92 92
Partials 68 68
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-aalam
requested review from
a team,
sfc-gh-jdu and
sfc-gh-stan
and removed request for
a team
sfc-gh-aalam
added
NO-CHANGELOG-UPDATES
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
@StefanUlbrich Could you please sign our CLA? We'd be happy to merge your PR afterwards! |
|
I have read the CLA Document and I hereby sign the CLA |
sorry for the delay. Thanks for reviewing |
sfc-gh-aalam
commented
Apr 28, 2023
remove shoutouts from changelog as it is not a consistent practice in the team
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-799415: Wrong type definitions (newtype instead of alias) snowflake-connector-python#1525 and SNOW-801097: Pyre type checker returns unexpected type errors with snowpark-python #810
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Test PR for user.