[SNOW-1645085] Always use SCOPED temp table for snowpark pandas generated api #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-yzou
added
NO-CHANGELOG-UPDATES
sfc-gh-yzou
force-pushed
the
yzou-SNOW-1645085-scoped-read-only
branch
2 times, most recently
from
81efaa7 to
378cf18
Compare
sfc-gh-yzou
requested review from
sfc-gh-nkumar,
sfc-gh-evandenberg and
sfc-gh-helmeleegy
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| #### Improvements | |||
|
|
|||
| - Improved `to_pandas` to persist the original timezone offset for TIMESTAMP_TZ type. | |||
| - Use SCOPED object for internal create temp tables. | |||
There was a problem hiding this comment.
maybe explain what this means here because it is not in open doc.
There was a problem hiding this comment.
added more contents
sfc-gh-helmeleegy
approved these changes
Sep 17, 2024
sfc-gh-yzou
force-pushed
the
yzou-SNOW-1645085-scoped-read-only
branch
from
b9d767e to
7c89443
Compare
sfc-gh-azhan
approved these changes
Sep 18, 2024
sfc-gh-yzou
force-pushed
the
yzou-SNOW-1645085-scoped-read-only
branch
from
a49af3d to
462ceb1
Compare
sfc-gh-yzou
force-pushed
the
yzou-SNOW-1645085-scoped-read-only
branch
from
462ceb1 to
edc51d6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
SNOW-1645085
Always use scoped temp table for internally created temp table during read_snowflake.
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
SCOPED temp object is feature introduced for snowpark internally created table, which is stored procedure scoped temp if the temp table is created within stored sproc, and session scoped if outside sored sproc.
Native app only allows usage of scoped object, similar as snowpark python, we always uses scoped object when enabled