Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-yzou committed Sep 17, 2024
1 parent 00ea971 commit 7c89443
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/snowflake/snowpark/modin/plugin/_internal/utils.py
Original file line number Diff line number Diff line change
@@ -285,7 +285,6 @@ def _create_read_only_table(
else STATEMENT_PARAMS.UNKNOWN,
}
statement_params.update(new_params)
# TODO: use snowpark save_as_table when user facing scoped object is supported
session.sql(
f"CREATE OR REPLACE {get_temp_type_for_object(use_scoped_temp_objects=use_scoped_temp_table, is_generated=True)} TABLE {temp_table_name} AS {ctas_query}"
).collect(statement_params=statement_params)
@@ -300,7 +299,7 @@ def _create_read_only_table(
STATEMENT_PARAMS.READONLY_TABLE_NAME: readonly_table_name,
}
)
# TODO: pushing read only table creation down to snowpark for general usage
# TODO (SNOW-1669224): pushing read only table creation down to snowpark for general usage
session.sql(
f"CREATE OR REPLACE {get_temp_type_for_object(use_scoped_temp_objects=use_scoped_temp_table, is_generated=True)} READ ONLY TABLE {readonly_table_name} CLONE {table_name}"
).collect(statement_params=statement_params)

0 comments on commit 7c89443

Please sign in to comment.