Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1418523: Remove session variable that can be local #2279

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

sfc-gh-aalam
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1418523

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    Minor refactor to handle thread-safe session. We remove _tmpdir_handler which is only used inside method _upload_unsupported_packages.

@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner September 11, 2024 23:25
@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 11, 2024
@sfc-gh-aalam sfc-gh-aalam enabled auto-merge (squash) September 12, 2024 22:46
@sfc-gh-aalam sfc-gh-aalam merged commit 8414933 into main Sep 17, 2024
36 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-SNOW-1418523-upload_unsupported_packages branch September 17, 2024 18:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants