Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1418523: Remove session variable that can be local #2279

Merged
merged 3 commits into from
Sep 17, 2024
Merged

SNOW-1418523: Remove session variable that can be local #2279

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc54e49
SNOW-1418523: Remove session param that can be local
sfc-gh-aalam Sep 11, 2024
16aeeca
minor fix
sfc-gh-aalam Sep 12, 2024
bce1031
Merge branch 'main' into aalam-SNOW-1418523-upload_unsupported_packages
sfc-gh-aalam Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/snowflake/snowpark/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,6 @@ def __init__(
)
self._custom_package_usage_config: Dict = {}
self._conf = self.RuntimeConfig(self, options or {})
self._tmpdir_handler: Optional[tempfile.TemporaryDirectory] = None
self._runtime_version_from_requirement: str = None
self._temp_table_auto_cleaner: TempTableAutoCleaner = TempTableAutoCleaner(self)
if self._auto_clean_up_temp_table_enabled:
Expand Down Expand Up @@ -1651,8 +1650,8 @@ def _upload_unsupported_packages(

try:
# Setup a temporary directory and target folder where pip install will take place.
self._tmpdir_handler = tempfile.TemporaryDirectory()
tmpdir = self._tmpdir_handler.name
tmpdir_handler = tempfile.TemporaryDirectory()
tmpdir = tmpdir_handler.name
target = os.path.join(tmpdir, "unsupported_packages")
if not os.path.exists(target):
os.makedirs(target)
Expand Down Expand Up @@ -1737,9 +1736,7 @@ def _upload_unsupported_packages(
for requirement in supported_dependencies + new_dependencies
]
)
metadata_local_path = os.path.join(
self._tmpdir_handler.name, metadata_file
)
metadata_local_path = os.path.join(tmpdir_handler.name, metadata_file)
with open(metadata_local_path, "w") as file:
for key, value in metadata.items():
file.write(f"{key},{value}\n")
Expand Down Expand Up @@ -1775,9 +1772,9 @@ def _upload_unsupported_packages(
f"-third-party-packages-from-anaconda-in-a-udf."
)
finally:
if self._tmpdir_handler:
self._tmpdir_handler.cleanup()
self._tmpdir_handler = None
if tmpdir_handler:
tmpdir_handler.cleanup()
tmpdir_handler = None

return supported_dependencies + new_dependencies

Expand Down
Loading