-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1638407 Added some simple tests for TimedeltaIndex
indexing
#2183
SNOW-1638407 Added some simple tests for TimedeltaIndex
indexing
#2183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also test a set case esp. an enlargement case.
for example, a df has timedelta index and now we do df.loc[pd.Timedelta('2 hours'),:] = x
) | ||
|
||
|
||
def test_df_with_timedelta_index_enlargement_during_indexing(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be possible for this test to be parametrized, rather than a sequence of SqlCounter blocks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would become more dense since some of the tests are run on snow_df["a"]
. If you still prefer that I parameterize the test I can try to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Varnika!
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1638407
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Added tests for:
TimedeltaIndex
.Series
andDataFrame
with aTimedeltaIndex
index.