Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-964034 Enable skipped multistmt tests for stored proc #1133

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

sfc-gh-sfan
Copy link
Collaborator

Description

We have to skip these tests before because we don't support result_scan and large result for multistmt queries. Now that these are supported, we could remove the skip

Testing

Regression test

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-964034

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-sfan sfc-gh-sfan requested a review from a team as a code owner November 7, 2023 23:54
@sfc-gh-sfan
Copy link
Collaborator Author

Precommit: https://ci-dev-142.int.snowflakecomputing.com/job/PythonStoredProcBuildPrecommitTest/693/console
Result: https://ci-dev-133.int.snowflakecomputing.com/job/RT-Precommit-Tests/12650/console

Unfortunately I don't have a BUWA link or a email, but I have the following in Jenkins log :)

2023-11-07 15:23:20  SUCCESS:   RT-PC-TestWorker #189269 (56 min)
2023-11-07 15:23:20            https://ci-dev-133.int.snowflakecomputing.com/job/RT-PC-TestWorker/189269/
2023-11-07 15:29:50  SUCCESS:   RT-PC-TestWorker #189268 (1 hr 2 min)
2023-11-07 15:29:50            https://ci-dev-133.int.snowflakecomputing.com/job/RT-PC-TestWorker/189268/
2023-11-07 15:38:12  SUCCESS:   RT-PC-TestWorker #189267 (1 hr 11 min)
2023-11-07 15:38:12            https://ci-dev-133.int.snowflakecomputing.com/job/RT-PC-TestWorker/189267/

@sfc-gh-sfan sfc-gh-sfan added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Nov 8, 2023
Description

We have to skip these tests before because we don't support
result_scan and large result for multistmt queries. Now that
these are supported, we could remove the skip

Testing

Regression test
@sfc-gh-sfan sfc-gh-sfan merged commit 2e36e3c into main Nov 11, 2023
51 checks passed
@sfc-gh-sfan sfc-gh-sfan deleted the shixuan_async_test branch November 11, 2023 00:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants