Skip to content

Commit

Permalink
SNOW-964034 Enable skipped multistmt tests for stored proc (#1133)
Browse files Browse the repository at this point in the history
Description

We have to skip these tests before because we don't support
result_scan and large result for multistmt queries. Now that
these are supported, we could remove the skip

Testing

Regression test
  • Loading branch information
sfc-gh-sfan authored Nov 11, 2023
1 parent db59f72 commit 2e36e3c
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions tests/integ/scala/test_async_job_suite.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,6 @@ def test_async_copy_into_location(session):
Utils.check_answer(res, df)


@pytest.mark.skipif(
IS_IN_STORED_PROC,
reason="TODO(SNOW-933567): result_scan for child job of multistmt is not supported",
)
@pytest.mark.skipif(IS_IN_STORED_PROC_LOCALFS, reason="Requires stage access")
@pytest.mark.skipif(not is_pandas_available, reason="to_pandas requires pandas")
def test_multiple_queries(session, resources_path):
Expand Down Expand Up @@ -362,10 +358,6 @@ def test_async_is_running_and_cancel(session):
assert async_job2.is_done()


@pytest.mark.skipif(
IS_IN_STORED_PROC,
reason="TODO(SNOW-933569): large result in multi-stmt is not supported in stored proc",
)
@pytest.mark.skipif(IS_IN_STORED_PROC_LOCALFS, reason="Requires large result")
def test_async_place_holder(session):
exp = session.sql("show functions").where("1=1").collect()
Expand Down

0 comments on commit 2e36e3c

Please sign in to comment.